gortiz commented on code in PR #10623:
URL: https://github.com/apache/pinot/pull/10623#discussion_r1170874777


##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/bloom/BloomIndexType.java:
##########
@@ -50,6 +50,7 @@
 public class BloomIndexType
     extends AbstractIndexType<BloomFilterConfig, BloomFilterReader, 
BloomFilterCreator>
     implements ConfigurableFromIndexLoadingConfig<BloomFilterConfig> {
+  public static final String INDEX_DISPLAY_NAME = "bloom";

Review Comment:
   It is a good practice to make these constants public. Specially in this 
case, where they can be useful if a code external to this class wants to 
analyze the TableConfig



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to