gortiz commented on code in PR #10623:
URL: https://github.com/apache/pinot/pull/10623#discussion_r1170878109


##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/fst/FstIndexType.java:
##########
@@ -167,4 +173,10 @@ protected TextIndexReader 
createIndexReader(PinotDataBuffer dataBuffer, ColumnMe
       return createIndexReader(dataBuffer, metadata);
     }
   }
+
+  @Override
+  public void convertToNewFormat(TableConfig tableConfig, Schema schema) {
+    super.convertToNewFormat(tableConfig, schema);

Review Comment:
   That is more or less the pattern we follow with `getConfig` and 
`createDeserializer`. I slightly prefer what @jugomezv suggest, but IMHO it is 
not a blocker.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to