gortiz commented on PR #10623: URL: https://github.com/apache/pinot/pull/10623#issuecomment-1514229317
> I think we should do two things: > > * Deprecate methods in `TableConfigBuilder` that do not construct the "new" format. > * Determine why/how we want to expose a controller API that returns the internal representation in the "new" format. Maybe one way of doing this is to bump the version of the controller API (to say, V2). About the _why_ part: The scope of this PR is to offer a way to make it easier to update TableConfigs to the latest syntax. This is something the users can do by their self, but given that it is an error prone but deterministic process, a tool is recommended. The new config method is easier to understand by humans and machines, so that is the why we want to expose a controller API. I don't get the _internal_ representation comment. Nothing is internal in the new config. Users can use this new syntax to configure indexes and in fact I created a PR changing the documentation in order to suggest users to use the new version (see https://github.com/pinot-contrib/pinot-docs/pull/162). About the _how_ part: I think deprecating methods and versioning the REST api is something interesting that we can discuss, but it is out of the scope of the task. We invested large amounts of time trying to keep backward compatibility. Therefore that theoretical v2 should support anything supported by v1, which make me thing that adding versioning here is not a blocker and can be done in another PR where we can discuss how to do that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
