siddharthteotia commented on code in PR #10684:
URL: https://github.com/apache/pinot/pull/10684#discussion_r1175934088
##########
pinot-query-planner/src/test/resources/queries/WindowFunctionPlans.json:
##########
@@ -1278,6 +1278,54 @@
"\n"
]
},
+ {
+ "description": "single OVER(ORDER BY) row_number and select col with
global order by on different column as inside over",
Review Comment:
What about corresponding runtime tests for these variants ? Especially for
the JOIN one ?
Can be done separately if not already covered
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
