somandal commented on code in PR #10684:
URL: https://github.com/apache/pinot/pull/10684#discussion_r1176734753


##########
pinot-query-planner/src/test/resources/queries/WindowFunctionPlans.json:
##########
@@ -1278,6 +1278,54 @@
           "\n"
         ]
       },
+      {
+        "description": "single OVER(ORDER BY) row_number and select col with 
global order by on different column as inside over",

Review Comment:
   Yeah the JOIN one needs a bit more work and I'll add that as part of 
RANK/DENSE_RANK support or as a separate PR to cover more JOIN scenarios. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to