walterddr commented on code in PR #10683:
URL: https://github.com/apache/pinot/pull/10683#discussion_r1178027383


##########
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/BaseServerStarter.java:
##########
@@ -545,6 +546,9 @@ public void start()
     InstanceDataManager instanceDataManager = 
_serverInstance.getInstanceDataManager();
     instanceDataManager.setSupplierOfIsServerReadyToServeQueries(() -> 
_isServerReadyToServeQueries);
     initSegmentFetcher(_serverConf);
+    // initialize the thread accountant for query killing
+    Tracing.ThreadAccountantOps
+        
.initializeThreadAccountant(_serverConf.subset(CommonConstants.PINOT_QUERY_SCHEDULER_PREFIX),
 _instanceId);

Review Comment:
   is this related to returning 205 instead of 200? the PR title is a bit 
misleading --> the error code change seems like a side product of the query 
killing?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to