walterddr commented on PR #10683: URL: https://github.com/apache/pinot/pull/10683#issuecomment-1526940948
> @walterddr agreed, I think we should consider the error codes holistically sometime, it is indeed a bit misleading right now. This PR should not affect the future refactoring right? I don't think we depend on hard coded number here? hmm. i think we should agree upon the error code convension we wanted to use first. until then we should make this PR's query killing behavior return 200 with attach the exception on the JSON return payload just like the rest of the error query response. since the return code is used by the REST client it would be particularly difficult for backward-compatibility modifications going forward (say tomorrow we decided to return a 4xx instead of 205) some browser will consider non-2xx as exception instead of an acceptable return which will cause confusion IMO -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
