walterddr commented on code in PR #10673:
URL: https://github.com/apache/pinot/pull/10673#discussion_r1179319906
##########
pinot-common/src/main/proto/worker.proto:
##########
@@ -70,23 +70,17 @@ message QueryResponse {
message StagePlan {
int32 stageId = 1;
- string instanceId = 2;
+ string virtualAddress = 2;
Review Comment:
- we will keep virtualAddress here indicating the host/port and workerID
together, cuz to a stage plan this will always be the same and non-nullable.
- for mailbox/opchain decoupling purpose we will use mailboxID as a unique
identifier generate from planner going forward and will be put into
StageMetadata/WorkerMetadata
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
