walterddr commented on code in PR #10673: URL: https://github.com/apache/pinot/pull/10673#discussion_r1179343509
########## pinot-query-planner/src/main/java/org/apache/pinot/query/routing/StageMetadata.java: ########## @@ -0,0 +1,92 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.query.routing; + +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import org.apache.pinot.core.routing.TimeBoundaryInfo; + + +/** + * {@code StageMetadata} is used to send stage-level info about the execution. + */ +public class StageMetadata { + private final List<WorkerMetadata> _workerMetadataList; + private final Map<String, String> _customProperties; + + public StageMetadata(List<WorkerMetadata> workerMetadataList, Map<String, String> customProperties) { + _workerMetadataList = workerMetadataList; + _customProperties = customProperties; + } + + public List<WorkerMetadata> getWorkerMetadataList() { + return _workerMetadataList; + } + + public Map<String, String> getCustomProperties() { + return _customProperties; + } + + public static class Builder { Review Comment: i am inclinde to use Builder/Extractor mechanism: PRO: - we can always extend & modify the Builder/Extractor easily without worry of changing the underlying StageMetadata format going forward. - usage is self-contained CON: - for all other custom fields, the user of the metadata classes needs to have their own custom String ser/de mechanism in order to ensure proper extraction of the metadata properties. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
