walterddr commented on code in PR #10886:
URL: https://github.com/apache/pinot/pull/10886#discussion_r1230240988
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/RelToPlanNodeConverter.java:
##########
@@ -178,12 +180,15 @@ private static PlanNode convertLogicalJoin(LogicalJoin
node, int currentStageId)
// Parse out all equality JOIN conditions
JoinInfo joinInfo = node.analyzeCondition();
- FieldSelectionKeySelector leftFieldSelectionKeySelector = new
FieldSelectionKeySelector(joinInfo.leftKeys);
- FieldSelectionKeySelector rightFieldSelectionKeySelector = new
FieldSelectionKeySelector(joinInfo.rightKeys);
+ JoinNode.JoinKeys joinKeys = new JoinNode.JoinKeys(new
FieldSelectionKeySelector(joinInfo.leftKeys),
+ new FieldSelectionKeySelector(joinInfo.rightKeys));
+ List<RexExpression> joinClause =
+
joinInfo.nonEquiConditions.stream().map(RexExpression::toRexExpression).collect(Collectors.toList());
+ boolean isColocatedJoin =
Review Comment:
this is not going to be generic enough. but we can refactor later.
(for example 32 partition join 16 partition on 4 servers)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
