walterddr commented on code in PR #10886:
URL: https://github.com/apache/pinot/pull/10886#discussion_r1230252471
##########
pinot-query-planner/src/test/java/org/apache/pinot/query/testutils/MockRoutingManagerFactory.java:
##########
@@ -178,6 +180,12 @@ public TimeBoundaryInfo getTimeBoundaryInfo(String
tableName) {
String.valueOf(System.currentTimeMillis() -
TimeUnit.DAYS.toMillis(1))) : null;
}
+ @Nullable
+ @Override
+ public TablePartitionInfo getTablePartitionInfo(String tableNameWithType) {
+ return null;
+ }
Review Comment:
chatted with @Jackie-Jiang offline, we should not mock the
TableDataManager/InstanceDataManager going forward, otherwise whenever the 2
main file changes we need to make sure the mock behavior aligns with the
change.
instead we should start them normally (TODO/follow up)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
