[GitHub] [pinot] shenyu0127 commented on a diff in pull request #11591: Throw exception when schema name doesn't match table name

[via GitHub]

shenyu0127 commented on code in PR #11591:
URL: https://github.com/apache/pinot/pull/11591#discussion_r1327366867


##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/UpsertTableIntegrationTest.java:
##########
@@ -245,14 +244,13 @@ protected void testDeleteWithFullUpsert(String 
kafkaTopicName, String tableName,
       }
     }, 100L, 600_000L, "Failed to load all upsert records for 
testDeleteWithFullUpsert");
 
-
     // Validate: pk is queryable and all columns are overwritten with new value
     rs = getPinotConnection()
         .execute("SELECT playerId, name, game FROM " + tableName + " WHERE 
playerId = 100").getResultSet(0);
     Assert.assertEquals(rs.getRowCount(), 1);
     Assert.assertEquals(rs.getInt(0, 0), 100);
     Assert.assertEquals(rs.getString(0, 1), "Zook-New");
-    Assert.assertEquals(rs.getString(0, 2), "null");
+    Assert.assertEquals(rs.getString(0, 2), "[\"null\"]");

Review Comment:
   This behavior is not expected.
   
   Your changes to `PinotHelixResourceManager.java` are unrelated to ingestion. 
Why would the behavior change?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org