xiangfu0 commented on PR #11591: URL: https://github.com/apache/pinot/pull/11591#issuecomment-1727022206
> I have a more general question on this PR. Should this PR not include places in pinot-spi where we can throw exception if a client tries to create a table config that does not have a schema with the same name? Right now, the `TableConfigBuilder` class accepts any schema as the schemaName. We should be throwing an exception there, so that these problems are caught earlier? Most of the users are using REST endpoint to POST a json table config to create table. It's ok to catch earlier in TableConfigBuilder, just the validation cannot be ignored from the server side. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
