walterddr commented on code in PR #11746:
URL: https://github.com/apache/pinot/pull/11746#discussion_r1348077435
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/SortOperator.java:
##########
@@ -164,6 +162,9 @@ private void consumeInputBlocks() {
_rows.addAll(container.subList(0, _numRowsToKeep - numRows));
LOGGER.debug("Early terminate at SortOperator - operatorId={},
opChainId={}", _operatorId,
_context.getId());
+ setEarlyTerminate();
Review Comment:
This is the only place where early terminate can be set --> and only acquire
one extra block b/c the downstream should guarantee after the early terminate
is set. the next block must've been a metadata block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
