walterddr commented on code in PR #11746:
URL: https://github.com/apache/pinot/pull/11746#discussion_r1353597355
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/exchange/BlockExchange.java:
##########
@@ -68,25 +67,29 @@ protected BlockExchange(List<SendingMailbox>
sendingMailboxes, BlockSplitter spl
_splitter = splitter;
}
- public void send(TransferableBlock block)
+ /**
+ * API to send a block to the destination mailboxes.
+ * @param block the block to be transferred
+ * @return true if any of the upstream mailboxes requested EOS (e.g. early
termination)
Review Comment:
yeah it is confusing, will create a separate PR for naming fix
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/MailboxSendOperator.java:
##########
@@ -147,12 +150,12 @@ protected TransferableBlock getNextBlock() {
}
}
- private void sendTransferableBlock(TransferableBlock block)
+ private boolean sendTransferableBlock(TransferableBlock block)
throws Exception {
- _exchange.send(block);
if (LOGGER.isDebugEnabled()) {
LOGGER.debug("==[SEND]== Block " + block + " sent from: " +
_context.getId());
}
+ return _exchange.send(block);
Review Comment:
hmm. i thought this was a bug b/c the word here is SEND not SENT :-/
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/AggregateOperator.java:
##########
@@ -64,19 +64,19 @@ public class AggregateOperator extends MultiStageOperator {
new
CountAggregationFunction(Collections.singletonList(ExpressionContext.forIdentifier("*")),
false);
private static final ExpressionContext PLACEHOLDER_IDENTIFIER =
ExpressionContext.forIdentifier("__PLACEHOLDER__");
- private final MultiStageOperator _inputOperator;
+ private final MultiStageOperator _upstreamOperator;
Review Comment:
yes some are named upstream some are named input. will revert this change
and make another PR to change the naming
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/InMemorySendingMailbox.java:
##########
@@ -33,7 +34,7 @@ public class InMemorySendingMailbox implements SendingMailbox
{
private final long _deadlineMs;
private ReceivingMailbox _receivingMailbox;
- private volatile boolean _isTerminated;
+ private volatile boolean _isEarlyTerminated;
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
