saurabhd336 commented on code in PR #11729:
URL: https://github.com/apache/pinot/pull/11729#discussion_r1353988984
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/reader/ForwardIndexReader.java:
##########
@@ -916,4 +919,67 @@ default byte[][] getBytesMV(int docId, T context) {
default int getNumValuesMV(int docId, T context) {
throw new UnsupportedOperationException();
}
+
+ /**
+ * This class represents the buffer byte ranges accessed while reading a
given docId.
+ * See {@link ValueRangeProvider} for more details.
+ */
+ @AllArgsConstructor
+ @EqualsAndHashCode
+ @Getter
+ class ValueRange {
+ private final long _offset;
+ private final int _sizeInBytes;
+
+ public static ValueRange newByteRange(long offset, int sizeInBytes) {
Review Comment:
Earlier we had a few variants here. Now it is indeed same as the
constructor. Removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]