Jackie-Jiang commented on code in PR #11729:
URL: https://github.com/apache/pinot/pull/11729#discussion_r1355906002
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/reader/ForwardIndexReader.java:
##########
@@ -916,4 +920,72 @@ default byte[][] getBytesMV(int docId, T context) {
default int getNumValuesMV(int docId, T context) {
throw new UnsupportedOperationException();
}
+
+ // Functions for recording absolute buffer byte ranges accessed while
reading a given docId
+
+ /**
+ * Returns whether the forward index supports recording the byte ranges
accessed while reading a given docId
+ */
+ default boolean isBufferByteRangeInfoSupported() {
+ return false;
+ }
+
+ /**
+ * Returns a list of {@link ByteRange} that represents all the distinct
Review Comment:
Let's add some javadoc stating only one set of the APIs (either fixed length
based or record based) should be used
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/reader/ForwardIndexReader.java:
##########
@@ -916,4 +920,72 @@ default byte[][] getBytesMV(int docId, T context) {
default int getNumValuesMV(int docId, T context) {
throw new UnsupportedOperationException();
}
+
+ // Functions for recording absolute buffer byte ranges accessed while
reading a given docId
+
+ /**
+ * Returns whether the forward index supports recording the byte ranges
accessed while reading a given docId
+ */
+ default boolean isBufferByteRangeInfoSupported() {
Review Comment:
Should we consider adding a method to return the underlying
`PinotDataBuffer`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
