klsince commented on code in PR #11740:
URL: https://github.com/apache/pinot/pull/11740#discussion_r1361219867
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##########
@@ -447,6 +467,9 @@ public RebalanceResult rebalance(TableConfig tableConfig,
RebalanceConfig rebala
// Check version and update IdealState
try {
+ if (_tableRebalanceObserver.isAborted()) {
+ throw new RuntimeException(String.format("Rebalance for table: %s
has been aborted", tableNameWithType));
Review Comment:
this leads to FAILED status, as I put the abort checks inside try-catch
blocks in TableRebalancer. the UNKNOWN_ERROR only happens when there is
unexpected (uncaught) exceptions, and such case is tracked by an error counter
to set alert on if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
