klsince commented on code in PR #11740:
URL: https://github.com/apache/pinot/pull/11740#discussion_r1361245932
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -1992,19 +1994,24 @@ public Map<String, Map<String, String>>
getAllJobsForTable(String tableNameWithT
for (ControllerJobType jobType : jobTypes) {
String jobsResourcePath =
ZKMetadataProvider.constructPropertyStorePathForControllerJob(jobType);
try {
+ if (!_propertyStore.exists(jobsResourcePath, -1)) {
Review Comment:
as tested, propertyStore.get() threw ZkNoNodeException. The current
try-catch would continue the for-loop upon this exception, but the warn logs
were kinda annoying, so I added the explicit existence check.
looks like no AccessOption is `-1`, but changed to PERSISTENT anyway
Updated: as it turned out, using `-1` as the option to get ZNode was why it
threw exception, because `-1` would set this specific option to true: `public
static int THROW_EXCEPTION_IFNOTEXIST = 16;`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
