walterddr commented on code in PR #12079:
URL: https://github.com/apache/pinot/pull/12079#discussion_r1419386491
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/physical/DispatchablePlanMetadata.java:
##########
@@ -35,18 +35,28 @@
/**
* The {@code DispatchablePlanMetadata} info contains the information for
dispatching a particular plan fragment.
*
- * <p>It contains information aboute:
+ * <p>It contains information
* <ul>
- * <li>the tables it is suppose to scan for</li>
- * <li>the underlying segments a stage requires to execute upon.</li>
- * <li>the server instances to which this stage should be execute on</li>
+ * <li>extracted from {@link
org.apache.pinot.query.planner.physical.DispatchablePlanVisitor}</li>
+ * <li>extracted from {@link
org.apache.pinot.query.planner.physical.PinotDispatchPlanner}</li>
* </ul>
*/
public class DispatchablePlanMetadata implements Serializable {
- // These 2 fields are extracted from TableScanNode
+
+ // --------------------------------------------------------------------------
+ // Fields extracted with {@link DispatchablePlanVisitor}
+ // --------------------------------------------------------------------------
+ // info from TableNode
private final List<String> _scannedTables;
private Map<String, String> _tableOptions;
+ // info from MailboxSendNode - whether a stage is pre-partitioned by the
same way the sending exchange desires
+ private boolean _isPrePartitioned;
Review Comment:
"pre" stands for the data input to the mailbox is "already" partitioned -->
isPartition is confusing b/c it can also mean the result of the mailbox is
partitioned
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
