walterddr commented on code in PR #12079:
URL: https://github.com/apache/pinot/pull/12079#discussion_r1419612768
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/routing/WorkerManager.java:
##########
@@ -333,26 +371,11 @@ private void
assignWorkersToIntermediateFragment(PlanFragment fragment, Dispatch
throw new IllegalStateException(
"No server instance found for intermediate stage for tables: " +
Arrays.toString(tableNames.toArray()));
}
- if (metadata.isRequiresSingletonInstance()) {
- // require singleton should return a single global worker ID with 0;
- metadata.setWorkerIdToServerInstanceMap(Collections.singletonMap(0,
- new
QueryServerInstance(serverInstances.get(RANDOM.nextInt(serverInstances.size())))));
- } else {
- Map<String, String> options = context.getPlannerContext().getOptions();
- int stageParallelism =
Integer.parseInt(options.getOrDefault(QueryOptionKey.STAGE_PARALLELISM, "1"));
- Map<Integer, QueryServerInstance> workerIdToServerInstanceMap = new
HashMap<>();
- int workerId = 0;
- for (ServerInstance serverInstance : serverInstances) {
- QueryServerInstance queryServerInstance = new
QueryServerInstance(serverInstance);
- for (int i = 0; i < stageParallelism; i++) {
- workerIdToServerInstanceMap.put(workerId++, queryServerInstance);
- }
- }
- metadata.setWorkerIdToServerInstanceMap(workerIdToServerInstanceMap);
- }
+ return serverInstances;
}
- private ColocatedTableInfo getColocatedTableInfo(String tableName, String
partitionKey, int numPartitions) {
+ private ColocatedTableInfo getColocatedTableInfo(String tableName, String
partitionKey, int numPartitions,
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
