swaminathanmanish opened a new pull request, #12546:
URL: https://github.com/apache/pinot/pull/12546
**Whats in the PR:**
Logging a warn message when no task is submitted, instead of throwing an
exception.
**Why its needed:**
The underlying task implementation need not generate a task for various
reasons (eg: not re-ingesting same data). When there are no issues with the
task trigger itself (eg: invalid inputs), we should not be throwing an
exception which misleads users of this API into thinking theres an issue in the
way, api is used. Also the logic in createTask does allow for empty task from
individual taskType. We can stick to a warn message when none of the taskTypes
generates a task. We do propagate the exception when there are invalid inputs
or underlying task implementation throws an exception.
if (pinotTaskConfigs.isEmpty()) {
LOGGER.warn("No ad-hoc task generated for task type: {}", taskType);
continue;
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
