swaminathanmanish commented on code in PR #12546:
URL: https://github.com/apache/pinot/pull/12546#discussion_r1511725705
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotTaskManager.java:
##########
@@ -212,7 +211,7 @@ public Map<String, String> createTask(String taskType,
String tableName, @Nullab
taskGenerator.getMaxAttemptsPerTask()));
}
if (responseMap.isEmpty()) {
- throw new NoTaskScheduledException("No task scheduled for 'tableName': "
+ tableName);
Review Comment:
Not sure the reason for throwing an exception. In the schedule case, we log
an info message. For schedule, its a valid case where there's no work to be
done. However this can be the case with adhoc as well, depending on the
underlying task implementation.
LOGGER.info("No task to schedule for task type: {}", taskType);
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
