abhioncbr commented on code in PR #12440: URL: https://github.com/apache/pinot/pull/12440#discussion_r1519539765
########## pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/V1Constants.java: ########## @@ -65,6 +65,8 @@ public static class MetadataKeys { public static class Segment { public static final String SEGMENT_CREATOR_VERSION = "creator.version"; public static final String SEGMENT_NAME = "segment.name"; + + public static final String SEGMENT_METADATA_VERSION = "segment.metadata.version"; Review Comment: I am planning to use this constant for writing new segment metadata, however that work I am planning to do in two other PRs. So, this is unused from this PR perspective. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org