Jackie-Jiang commented on code in PR #12440: URL: https://github.com/apache/pinot/pull/12440#discussion_r1554426108
########## pinot-spi/src/test/resources/segment-metadata-with-version-header.properties: ########## @@ -0,0 +1,125 @@ +# segment.metadata.version=version1 Review Comment: Why is it start from `version1`? I'd suggest treating the one without header as version 1, and the new format starts as version 2. Also suggest simplifying it as `# version=2`. This is a general setting for all configurations, instead of just the segment metadata -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
