zhtaoxiang commented on code in PR #12739:
URL: https://github.com/apache/pinot/pull/12739#discussion_r1547100308
##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/ValidationMetrics.java:
##########
@@ -133,124 +134,126 @@ public ValidationMetrics(PinotMetricsRegistry
metricsRegistry) {
/**
* Updates the missing segment count gauge.
*
- * @param resource The resource for which the gauge is updated
+ * @param tableNameWithType The table name with type for which the gauge is
updated
Review Comment:
since we are changing the comment and parameter names now: can we change to
table name with type and database?
##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/AbstractMetrics.java:
##########
@@ -796,6 +809,7 @@ private void removeGaugeFromMetricRegistry(String
metricName) {
protected abstract G[] getGauges();
protected String getTableName(String tableName) {
- return _isTableLevelMetricsEnabled || _allowedTables.contains(tableName) ?
tableName : "allTables";
+ tableName = _isTableLevelMetricsEnabled ||
_allowedTables.contains(tableName) ? tableName : "allTables";
+ return StringUtils.replaceOnce(tableName, ".", "#");
Review Comment:
can we please add some comments to explain why we need this change? this
will make the code easy to read and understand
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
