shounakmk219 commented on code in PR #12739:
URL: https://github.com/apache/pinot/pull/12739#discussion_r1547114035
##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/ValidationMetrics.java:
##########
@@ -133,124 +134,126 @@ public ValidationMetrics(PinotMetricsRegistry
metricsRegistry) {
/**
* Updates the missing segment count gauge.
*
- * @param resource The resource for which the gauge is updated
+ * @param tableNameWithType The table name with type for which the gauge is
updated
Review Comment:
Good question. All internal pinot references to tableName/ rawTableName /
tableNameWithType are prefixed with database name by design so we are skipping
specifying it in the variable name. External table name inputs are translated
at entry itself to maintain the convention for internal use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
