klsince commented on code in PR #12694:
URL: https://github.com/apache/pinot/pull/12694#discussion_r1554386583


##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/TableUpsertMetadataManager.java:
##########
@@ -50,4 +53,6 @@ public interface TableUpsertMetadataManager extends Closeable 
{
    * @return A {@code Map} where keys are partition id and values are count of 
primary keys for that specific partition
    */
   Map<Integer, Long> getPartitionToPrimaryKeyCount();
+
+  List<SegmentContext> getSegmentContexts(List<IndexSegment> selectedSegments);

Review Comment:
   good point



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to