Jackie-Jiang commented on code in PR #12694:
URL: https://github.com/apache/pinot/pull/12694#discussion_r1556437699
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java:
##########
@@ -433,6 +435,14 @@ public Map<String, SegmentErrorInfo> getSegmentErrors() {
}
}
+ @Override
+ public List<SegmentContext> getSegmentContexts(List<IndexSegment>
selectedSegments,
+ Map<String, String> queryOptions) {
+ List<SegmentContext> segmentContexts = new ArrayList<>();
Review Comment:
(minor)
```suggestion
List<SegmentContext> segmentContexts = new
ArrayList<>(selectedSegments.size());
```
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java:
##########
@@ -300,6 +303,17 @@ public void onConsumingToOnline(String segmentNameStr) {
_ingestionDelayTracker.markPartitionForVerification(segmentName.getPartitionGroupId());
}
+ @Override
+ public List<SegmentContext> getSegmentContexts(List<IndexSegment>
selectedSegments,
+ Map<String, String> queryOptions) {
+ List<SegmentContext> segmentContexts = new ArrayList<>();
Review Comment:
(minor)
```suggestion
List<SegmentContext> segmentContexts = new
ArrayList<>(selectedSegments.size());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
