tibrewalpratik17 commented on code in PR #12602:
URL: https://github.com/apache/pinot/pull/12602#discussion_r1570045128
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -1758,6 +1769,12 @@ private void updateCurrentDocumentCountMetrics() {
_segmentLogger.info(
"Consumed {} events from (rate:{}/s), currentOffset={},
numRowsConsumedSoFar={}, numRowsIndexedSoFar={}",
rowsConsumed, consumedRate, _currentOffset, _numRowsConsumed,
_numRowsIndexed);
+ if (_filteredMessageOffsets.size() > 0) {
+ if (_trackFilteredMessageOffsets) {
Review Comment:
I left it on purpose if anyone changes the logic to pushing to
_filteredMessageOffsets in the future for any other usecase we can still ensure
that the config is enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
