tibrewalpratik17 commented on code in PR #12602:
URL: https://github.com/apache/pinot/pull/12602#discussion_r1527244008
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -1743,6 +1752,12 @@ private void updateCurrentDocumentCountMetrics() {
rowsConsumed, consumedRate, _currentOffset, _numRowsConsumed,
_numRowsIndexed);
_lastConsumedCount = _numRowsConsumed;
_lastLogTime = now;
+ if (_filteredMessageOffsets.size() > 0) {
+ if (_trackFilteredMessageOffsets) {
+ _segmentLogger.info("Filtered events with offsets: {}",
_filteredMessageOffsets);
Review Comment:
Hmm this sublist length may vary from user to user.. some way want 50 some
may want 5-10.. how about we leave this to the log-truncation logic on the user
side itself? As this log statement is behind a config, user might expect a
long-line and should be relatively safe. We can revisit this later if we feel
this is creating a lot of logging nuisance. Wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
