itschrispeck commented on PR #13005: URL: https://github.com/apache/pinot/pull/13005#issuecomment-2080301442
> Why not just replace the implementation to keep the interface simple and easy to use? If Java's built in regular expressions have the edge _somewhere_, it's probably a pretty small edge, and it would be nice to avoid backtracking by default. I don't have a good understanding of how Pinot's users use regex, but from searching it seems that the median latency/memory usage of re2j is higher than Java's built in library. It'd also become a backwards incompatible change due to feature gaps. In general I don't _think_ users would be using Pinot for expensive regex filtering, but that's my conjecture. Some references: https://github.com/DaniilRoman/re2j_test https://github.com/google/re2j/issues/162 https://github.com/google/re2j/issues/12 If there is a consensus that an outright replacement is acceptable I'm happy to go that route. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
