itschrispeck commented on code in PR #13094: URL: https://github.com/apache/pinot/pull/13094#discussion_r1593319012
########## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/mutable/MutableSegmentImpl.java: ########## @@ -216,6 +217,7 @@ public boolean isMutableSegment() { _partitionFunction = config.getPartitionFunction(); _mainPartitionId = config.getPartitionId(); _nullHandlingEnabled = config.isNullHandlingEnabled(); + _consumerDir = config.getConsumerDir() != null ? new File(config.getConsumerDir()) : null; Review Comment: That's a good point, it can be null in the `MemoryEstimator` path. I think it's probably clearer to set a dummy dir there, and remove the `@Nullable` annotation for consumerDir For the realtime flow `RealtimeTableDataManager.getConsumerDir()` ensures it will not be null. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org