Jackie-Jiang commented on code in PR #13094:
URL: https://github.com/apache/pinot/pull/13094#discussion_r1597287473
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/invertedindex/RealtimeLuceneTextIndex.java:
##########
@@ -78,7 +78,7 @@ public RealtimeLuceneTextIndex(String column, File
segmentIndexDir, String segme
// for realtime
_indexCreator =
new LuceneTextIndexCreator(column, new
File(segmentIndexDir.getAbsolutePath() + "/" + segmentName),
- false /* commitOnClose */, true, null, config);
+ false /* commitOnClose */, true, null, null, config);
Review Comment:
Seems like you are passing in `null` as `consumerDir` here. Do we have a
test covering this path? I'd imagine it should throw NPE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
