rohityadav1993 commented on code in PR #13107:
URL: https://github.com/apache/pinot/pull/13107#discussion_r1617728542
##########
pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-common/src/main/java/org/apache/pinot/plugin/ingestion/batch/common/SegmentGenerationTaskRunner.java:
##########
@@ -159,14 +161,24 @@ private SegmentNameGenerator
getSegmentNameGenerator(SegmentGeneratorConfig segm
Boolean.parseBoolean(segmentNameGeneratorConfigs.get(EXCLUDE_SEQUENCE_ID)),
IngestionConfigUtils.getBatchSegmentIngestionType(tableConfig),
IngestionConfigUtils.getBatchSegmentIngestionFrequency(tableConfig),
dateTimeFormatSpec,
- segmentNameGeneratorConfigs.get(SEGMENT_NAME_POSTFIX),
- appendUUIDToSegmentName);
+ segmentNameGeneratorConfigs.get(SEGMENT_NAME_POSTFIX),
appendUUIDToSegmentName);
case BatchConfigProperties.SegmentNameGeneratorType.INPUT_FILE:
String inputFileUri =
_taskSpec.getCustomProperty(BatchConfigProperties.INPUT_DATA_FILE_URI_KEY);
return new
InputFileSegmentNameGenerator(segmentNameGeneratorConfigs.get(FILE_PATH_PATTERN),
- segmentNameGeneratorConfigs.get(SEGMENT_NAME_TEMPLATE),
- inputFileUri,
- appendUUIDToSegmentName);
+ segmentNameGeneratorConfigs.get(SEGMENT_NAME_TEMPLATE),
inputFileUri, appendUUIDToSegmentName);
+ case BatchConfigProperties.SegmentNameGeneratorType.UPLOADED_REALTIME:
+ Preconditions.checkState(segmentGeneratorConfig.getCreationTime() !=
null,
+ "Creation time must be set for uploaded realtime segment name
generator");
+
Preconditions.checkState(segmentGeneratorConfig.getUploadedSegmentPartitionId()
!= -1,
+ "Valid partition id must be set for uploaded realtime segment name
generator");
Review Comment:
Do you mean for validation?
The sequenceId is sent as part of SegmentNameGenerator method interface
https://github.com/apache/pinot/blob/c2b1132c7e5f5b3e60155466debfb42ff3aa192d/pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/creator/name/SegmentNameGenerator.java#L40
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
