This is an automated email from the ASF dual-hosted git repository.
jiaguo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 3d07b90bd7 Fix Logging Location for CPU-Based Query Killing (#13318)
3d07b90bd7 is described below
commit 3d07b90bd7568292295149fb7fe965f3b2605d78
Author: PraveenVora <praveenc2...@gmail.com>
AuthorDate: Thu Jun 6 01:59:02 2024 +0530
Fix Logging Location for CPU-Based Query Killing (#13318)
* fix logging
* fix logging
---------
Co-authored-by: pchaganl <pchagan...@linkedin.com>
---
.../pinot/core/accounting/PerQueryCPUMemAccountantFactory.java | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
a/pinot-core/src/main/java/org/apache/pinot/core/accounting/PerQueryCPUMemAccountantFactory.java
b/pinot-core/src/main/java/org/apache/pinot/core/accounting/PerQueryCPUMemAccountantFactory.java
index 5b724f4a0f..598b68b344 100644
---
a/pinot-core/src/main/java/org/apache/pinot/core/accounting/PerQueryCPUMemAccountantFactory.java
+++
b/pinot-core/src/main/java/org/apache/pinot/core/accounting/PerQueryCPUMemAccountantFactory.java
@@ -827,8 +827,9 @@ public class PerQueryCPUMemAccountantFactory implements
ThreadAccountantFactory
for (Map.Entry<String, AggregatedStats> entry :
_aggregatedUsagePerActiveQuery.entrySet()) {
AggregatedStats value = entry.getValue();
if (value._cpuNS > _cpuTimeBasedKillingThresholdNS) {
- LOGGER.error("Query {} got picked because using {} ns of cpu time,
greater than threshold {}",
- value._queryId, value.getCpuNS(),
_cpuTimeBasedKillingThresholdNS);
+ LOGGER.error("Current task status recorded is {}. Query {} got
picked because using {} ns of cpu time,"
+ + " greater than threshold {}", _threadEntriesMap,
value._queryId, value.getCpuNS(),
+ _cpuTimeBasedKillingThresholdNS);
value._exceptionAtomicReference.set(new RuntimeException(
String.format("Query %s got killed on %s: %s because using %d "
+ "CPU time exceeding limit of %d ns CPU time",
@@ -836,7 +837,6 @@ public class PerQueryCPUMemAccountantFactory implements
ThreadAccountantFactory
interruptRunnerThread(value.getAnchorThread());
}
}
- LOGGER.error("Current task status recorded is {}", _threadEntriesMap);
}
private void interruptRunnerThread(Thread thread) {
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
