Jackie-Jiang commented on code in PR #13355:
URL: https://github.com/apache/pinot/pull/13355#discussion_r1634019517
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/store/StarTreeIndexReader.java:
##########
@@ -67,17 +66,11 @@ public class StarTreeIndexReader implements Closeable {
*/
public StarTreeIndexReader(File segmentDirectory, SegmentMetadataImpl
segmentMetadata, ReadMode readMode)
throws IOException, ConfigurationException {
- Preconditions.checkNotNull(segmentDirectory);
Review Comment:
Yes. It is internal class, thus we can control all the caller behavior. We
usually annotate argument that can be null with `@Nullable`, and skip the null
check for performance reason
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
