Jackie-Jiang commented on code in PR #13355: URL: https://github.com/apache/pinot/pull/13355#discussion_r1634019815
########## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/store/SegmentLocalFSDirectory.java: ########## @@ -268,7 +267,7 @@ private synchronized void loadData() default: break; } - if (CollectionUtils.isNotEmpty(_segmentMetadata.getStarTreeV2MetadataList())) { + if (_segmentMetadata.getStarTreeV2MetadataList() != null) { Review Comment: It cannot be empty, only null or non-empty. I modified this place to make it consistent with other callers -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org