tibrewalpratik17 commented on issue #13629: URL: https://github.com/apache/pinot/issues/13629#issuecomment-2233878304
Thanks for the reply @jackjlli! > I'd suggest collecting more stats from your side for M3 and see if there is any potential race condition that could occur. Hmm this might be a bigger effort on our end as we will have to scope this out with the centralised observability team. > this cleanupMetrics() method is very essential to be invoked, as there is no guarantee that new consuming segments for the same partition will always be assigned to the same realtime pinot-server. What about upsert tables? Pinot guarantees for upsert tables the consuming segments will be in the same partition. Can we change the logic to set gauge value to 0 instead of removing from metrics-registry specifically for upsert tables? I am setting to 0 as table rebalance might be the only reason that would change partition <> host mapping for upsert tables. This will cover most of the use-cases at Uber where we are trying to put alerts on this metric for tracking consumption. Let me know your thoughts on this! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
