tarun11Mavani opened a new pull request, #13792: URL: https://github.com/apache/pinot/pull/13792
In #9605, we introduced a change to not resolve non-aggregation group by queries into distinct query, if select clause is not exactly matching to group-by clause. This is a breaking change for our customer as existing query stopped working for us. To fix this, instead of throwing an exception, we can return original query and let pinot handle the query as group-by query. We already have a [validateGroupByClause](https://github.com/apache/pinot/blob/53fbf88027c47b3c6f7d1526576ba0bd257fe9d5/pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java#L181) that recursively checks if an expression contains any reference not appearing in the GROUP BY clause. So we don't need to verify the same in NonAggregationGroupByToDistinctQueryRewriter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
