tibrewalpratik17 commented on code in PR #13792:
URL: https://github.com/apache/pinot/pull/13792#discussion_r1713030201
##########
pinot-common/src/test/java/org/apache/pinot/sql/parsers/rewriter/NonAggregationGroupByToDistinctQueryRewriterTest.java:
##########
@@ -53,13 +53,23 @@ private void testQueryRewrite(String original, String
expected) {
@Test
public void testUnsupportedQueries() {
- testUnsupportedQuery("SELECT col1 FROM foo GROUP BY col1, col2");
testUnsupportedQuery("SELECT col1, col2 FROM foo GROUP BY col1");
- testUnsupportedQuery("SELECT col1 + col2 FROM foo GROUP BY col1, col2");
+ testUnsupportedQuery("SELECT concat(col1, col2) FROM foo GROUP BY col1");
Review Comment:
shouldn't this type of query be also supported but not re-writed? can you
confirm mysql / postgresql behaviour in case of concat?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
