Jackie-Jiang commented on code in PR #13863:
URL: https://github.com/apache/pinot/pull/13863#discussion_r1725622725
##########
pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java:
##########
@@ -178,6 +178,15 @@ public static class ControllerPeriodicTasksConf {
public static final String
DEPRECATED_SEGMENT_RELOCATOR_FREQUENCY_IN_SECONDS =
"controller.segment.relocator.frequencyInSeconds";
public static final String SEGMENT_RELOCATOR_FREQUENCY_PERIOD =
"controller.segment.relocator.frequencyPeriod";
+
+ //whether segment relocator should do a best-efforts rebalance. Default is
'true'
+ public static final String SEGMENT_RELOCATOR_BEST_EFFORTS =
"controller.segment.relocator.bestEfforts";
+ //For no-downtime rebalance, minimum number of replicas to keep alive
during rebalance, or maximum number of
+ // replicas allowed to be unavailable if value is negative. Default value
is -1
+ public static final String SEGMENT_RELOCATOR_MIN_AVAIL_REPLICAS =
"controller.segment.relocator.minAvailReplicas";
Review Comment:
Suggest keeping the name align with `RebalanceConfig`:
`controller.segment.relocator.minAvailableReplicas` and
`controller.segment.relocator.bootstrap`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
