suddendust commented on code in PR #13863:
URL: https://github.com/apache/pinot/pull/13863#discussion_r1726923462
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/relocation/SegmentRelocator.java:
##########
@@ -169,6 +179,10 @@ private void rebalanceTable(String tableNameWithType) {
rebalanceConfig.setExternalViewCheckIntervalInMs(_externalViewCheckIntervalInMs);
rebalanceConfig.setExternalViewStabilizationTimeoutInMs(_externalViewStabilizationTimeoutInMs);
rebalanceConfig.setUpdateTargetTier(TierConfigUtils.shouldRelocateToTiers(tableConfig));
+ //Do not fail the rebalance when the no-downtime contract cannot be
achieved
+ rebalanceConfig.setBestEfforts(_bestEffortsRebalance);
+ rebalanceConfig.setReassignInstances(_reassignInstancesDuringRebalance);
+ rebalanceConfig.setBootstrap(_bootstrapServersDuringRebalance);
Review Comment:
Yes, added `downtime` that defaults to `false`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
