gortiz commented on code in PR #14226: URL: https://github.com/apache/pinot/pull/14226#discussion_r1808426097
########## pinot-broker/src/test/java/org/apache/pinot/broker/queryquota/HelixExternalViewBasedQueryQuotaManagerTest.java: ########## @@ -18,6 +18,8 @@ */ package org.apache.pinot.broker.queryquota; +import com.google.common.util.concurrent.RateLimiter; +import com.google.common.util.concurrent.TestRateLimiter; Review Comment: Wow! That was unexpected. Unless a major force, never, ever, ever create a class on a third party package. That is basically forbidden when using module paths. If there is a reason why we need to do it here (like being able to call a package protected method) it is a very strong reason to do not use RateLimiter API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
