bziobrowski commented on code in PR #14226: URL: https://github.com/apache/pinot/pull/14226#discussion_r1808897188
########## pinot-broker/src/test/java/org/apache/pinot/broker/queryquota/HelixExternalViewBasedQueryQuotaManagerTest.java: ########## @@ -18,6 +18,8 @@ */ package org.apache.pinot.broker.queryquota; +import com.google.common.util.concurrent.RateLimiter; +import com.google.common.util.concurrent.TestRateLimiter; Review Comment: Ok, I'll move the change if it's so problematic. Out of curiosity - what damage this class could do being limited to tests that explicitly set it up and only used in a single test ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
