Jackie-Jiang commented on code in PR #14479:
URL: https://github.com/apache/pinot/pull/14479#discussion_r1849687959
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/mutable/MutableSegmentImpl.java:
##########
@@ -797,6 +801,18 @@ private void addNewRow(int docId, GenericRow row) {
recordIndexingError(indexEntry.getKey(), e);
}
}
+
+ if (_thresholdForNumOfColValuesEnabled) {
+ int prevCount = indexContainer._valuesInfo.getNumValues();
+ long newCount = prevCount + 1L + values.length;
Review Comment:
For now we can figure out a conservative value that will never cause over
2GB buffer. Once we support larger index, we can increate this value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
