Harnoor7 commented on code in PR #14479:
URL: https://github.com/apache/pinot/pull/14479#discussion_r1850202734
##########
pinot-common/src/main/java/org/apache/pinot/common/protocols/SegmentCompletionProtocol.java:
##########
@@ -149,6 +149,7 @@ public enum ControllerResponseStatus {
public static final String REASON_END_OF_PARTITION_GROUP =
"endOfPartitionGroup";
// Stop reason sent by server as force commit message received
public static final String REASON_FORCE_COMMIT_MESSAGE_RECEIVED =
"forceCommitMessageReceived";
+ public static final String REASON_NUM_OF_COL_VALUES_ABOVE_THRESHOLD =
"numColValuesAboveThreshold";
Review Comment:
Considering new impln now where we are keeping conservative size estimation
check as well, I guess it makes sense to enable this change only behind a flag?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
