Jackie-Jiang commented on code in PR #14601:
URL: https://github.com/apache/pinot/pull/14601#discussion_r1871905883
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/CompositeTransformer.java:
##########
@@ -82,12 +90,37 @@ public class CompositeTransformer implements
RecordTransformer {
* </ul>
*/
public static List<RecordTransformer> getDefaultTransformers(TableConfig
tableConfig, Schema schema) {
- return Stream.of(new ExpressionTransformer(tableConfig, schema), new
FilterTransformer(tableConfig),
- new SchemaConformingTransformer(tableConfig, schema),
- new SchemaConformingTransformerV2(tableConfig, schema), new
DataTypeTransformer(tableConfig, schema),
- new TimeValidationTransformer(tableConfig, schema), new
SpecialValueTransformer(schema),
- new NullValueTransformer(tableConfig, schema), new
SanitizationTransformer(schema)).filter(t -> !t.isNoOp())
- .collect(Collectors.toList());
+ List<RecordTransformer> transformers = new ArrayList<>();
+ IngestionConfig ingestionConfig = tableConfig.getIngestionConfig();
+ if (ingestionConfig != null) {
+ List<EnrichmentConfig> enrichmentConfigs =
ingestionConfig.getEnrichmentConfigs();
Review Comment:
I think having a separate `EnrichmentConfig` is okay. Similarly we have
separate `FilterConfig`, `ComplexTypeConfig`, and each of them is powered by a
`RecordTransformer`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
