Jackie-Jiang commented on code in PR #14601:
URL: https://github.com/apache/pinot/pull/14601#discussion_r1874024636
##########
pinot-plugins/pinot-segment-writer/pinot-segment-writer-file-based/src/main/java/org/apache/pinot/plugin/segmentwriter/filebased/FileBasedSegmentWriter.java:
##########
@@ -141,6 +141,7 @@ private void resetBuffer()
@Override
public void collect(GenericRow row)
throws IOException {
+ // TODO: Revisit whether we should transform the row
Review Comment:
In `flush()` we will use the collected row to create a segment, which
applies the transforms again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
