bziobrowski commented on code in PR #14662:
URL: https://github.com/apache/pinot/pull/14662#discussion_r1905095713
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/config/QueryOptionsUtils.java:
##########
@@ -241,6 +241,20 @@ public static Integer getGroupTrimThreshold(Map<String,
String> queryOptions) {
return uncheckedParseInt(QueryOptionKey.GROUP_TRIM_THRESHOLD,
groupByTrimThreshold);
}
+ @Nullable
+ public static Integer getNumThreadsForFinalReduce(Map<String, String>
queryOptions) {
+ String numThreadsForFinalReduceString =
queryOptions.get(QueryOptionKey.NUM_THREADS_FOR_FINAL_REDUCE);
+ return checkedParseInt(QueryOptionKey.NUM_THREADS_FOR_FINAL_REDUCE,
numThreadsForFinalReduceString, 1);
+ }
+
Review Comment:
I reckon it'd be good to increase the minimum for parallel chunk size (e.g.
100) because if a malicious (or unaware) users sets it to 1 and the number of
records to reduce in final phase is large, it'd result in creating lots of
futures and significant slowdown.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
